Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Searching Data Source Nodes Source URL #11538

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

flvndvd
Copy link
Contributor

@flvndvd flvndvd commented Mar 21, 2025

Description

This PR adds support in the Core API to search for source URLs. This will be used later on in the input bar as a fallback if the "homemade" algorithm to decipher URL to get the node id does not work. For now, it's only wired in the attach dropdown.

SourceURL

Tests

Risk

Deploy Plan

@flvndvd flvndvd marked this pull request as ready for review March 21, 2025 16:06
Copy link
Contributor

@JulesBelveze JulesBelveze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 🔥

@flvndvd flvndvd merged commit 000ac68 into main Mar 21, 2025
7 checks passed
Copy link
Contributor

@aubin-tchoi aubin-tchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@flvndvd flvndvd deleted the flav/support-searching-by-url branch March 21, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants