Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder: Add a Select All buttons if all results comes from Salesforce in search results popover #11536

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PopDaph
Copy link
Contributor

@PopDaph PopDaph commented Mar 21, 2025

Description

We want to be able to add a "Select All" button from the search results in the Assistant Builder.
Figma is here: https://www.figma.com/design/QOxHwppG64GtPocpDhS6Y7/Product?node-id=2389-13138&p=f&t=zpmjmIzpiXyO6Nei-0

To be perfectly usable we think it needs to come with some way to filter from a datasource. This is a bit more work then just allowing to Select all. To be able to ship this quickly for Salesforce for which it's a real pain point to not be able to select multiple items at the time, I gated this new button to salesforce only.

Meaning this button appears only if all the results come from Salesforce and we're in the Builder.

Screenshot 2025-03-21 at 16 06 36

Tests

Locally.

Risk

Can be rolled back.

Deploy Plan

Deploy front.

@@ -119,6 +125,9 @@ export default function AssistantBuilderDataSourceModal({
/>
</div>
</SheetContainer>
<div className="flex flex-col border-t border-border/60 bg-background p-3 text-sm dark:border-border-night/60 dark:bg-background-night">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😇

Copy link
Contributor

@JulesBelveze JulesBelveze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit 👌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants