Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate Group Ids on Conversation #11529

Merged
merged 1 commit into from
Mar 21, 2025
Merged

Deduplicate Group Ids on Conversation #11529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions front/lib/api/assistant/conversation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2032,15 +2032,20 @@ export async function updateConversationRequestedGroupIds(
conversation: ConversationType,
t: Transaction
): Promise<void> {
const newRequirements = mentionedAgents.flatMap(
(agent) => agent.requestedGroupIds
// Sort and deduplicate new requirements.
const newRequirements = _.uniqWith(
mentionedAgents.flatMap((agent) =>
agent.requestedGroupIds.map((req) => sortBy(req))
),
isEqual
);
const currentRequirements = conversation.requestedGroupIds;

// Check if each new requirement already exists in current requirements.
const areAllRequirementsPresent = newRequirements.every((newReq) =>
currentRequirements.some((currentReq) =>
isEqual(sortBy(newReq), sortBy(currentReq))
currentRequirements.some(
// newReq was sorted, so we need to sort currentReq as well.
(currentReq) => isEqual(newReq, sortBy(currentReq))
)
);

Expand All @@ -2053,7 +2058,8 @@ export async function updateConversationRequestedGroupIds(
const requirementsToAdd = newRequirements.filter(
(newReq) =>
!currentRequirements.some((currentReq) =>
isEqual(sortBy(newReq), sortBy(currentReq))
// newReq was sorted, so we need to sort currentReq as well.
isEqual(newReq, sortBy(currentReq))
)
);

Expand Down