[v1 API - tables] Use default title for tables #11526
Conversation
Description --- Fixes [this monitor](https://dust4ai.slack.com/archives/C05F84CFP0E/p1742553570819939) Aligns with what was done for documents of providing a default title. Risk --- standard Deploy --- front
|
|
PMRR |
philipperolet
added
the
documentation-ack
| @@ -687,6 +683,8 @@ export async function upsertTable({ | |||
| standardizedSourceUrl = standardized; | |||
| } | |||
|
|
|||
| const title = titleEmpty ? UNTITLED_TITLE : params.title; | |||
There was a problem hiding this comment.
here it would be "Untitled Table" no?
There was a problem hiding this comment.
I thought about it and IMO better to have one unified "UNTITLED_TITLE"
There was a problem hiding this comment.
we could still have UNTITLED_DOCUMENT_TITLE, UNTITLED_TABLE_TITLE and UNTITLED_FOLDER_TITLE defined at the same place? but ofc this is only a fallback since each connector should provide better names
There was a problem hiding this comment.
so totally up to you, i'm fine with anything 👍
There was a problem hiding this comment.
Thanks :) I think it's better to have only one, despite the downside of it being a bit unaccurate. An option would be to rename "[untitled]", will do that if we ever hear about this again
Description
Fixes this monitor
Aligns with what was done for documents of providing a default title.
Risk
standard
Deploy
front