Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We encountered a critical issue with our public API where legitimate requests were being blocked due to overly restrictive CORS handling in our middleware (original PR here).
Root Cause
Our middleware was implementing CORS checks that:
Origin
header for all requests to/api/v1/*
endpointsfront-ext.dust.tt
This caused several problems:
Impact
This affected:
Solution
We implemented a more nuanced CORS handling approach:
Non-CORS Requests
CORS Requests
Headers and Methods
Testing
I was able to reproduce locally the issue, and I confirm that this fixes it.
To verify the fix:
Tests
Risk
Deploy Plan