Assistant Builder: Can't select both remote and non-remote tables on the same Table Query action #11520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the same Table Query action
Fraggle
approved these changes
Mar 21, 2025
|
The filtering logic was not applied, on prod you can select both snowflake and some tables in Notion. First fix is to make sure the filtering is applied: you can check on front-edge Second fix is to use the filtered datasource views on the search endpoint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code that filters the datasource views to ensure if you're in table query you select only non-remote or only remote tables was not working anymore. We could select tables from both kind and end up with this error:
This PR fixes the filtering logic + use the filtered data source views on the search endpoint to ensure we're searching applying the proper filter.
Tests
Locally.
Risk
Break the data source selector on the Builder.
Can be safely rollback.
Deploy Plan
Deploy front.