[Attach] Allow semantic searching content node documents

[philipperolet]

Fixes #2404

Description

As per title and issue.

Extracted from #11489 (cf comments)

Risks

standard

Deploy

front

[spolu]

Not sure I understand.

I thought we wanted to have one action per attached folders?

Is the intent here to allow searching in attached files? Aren't we supposed to change the isSearchable in the list files as well?

How will that work when we start allowing folders?

[spolu]

Can we rename this one to make it clear it's the conversation data source right?

[spolu]

You're taking the whole dataSourceView?

[philipperolet]

No, I should have the content node id as parent filter, thanks for noticing 👍

[philipperolet]

Not sure I understand.

I thought we wanted to have one action per attached folders?

Is the intent here to allow searching in attached files? Aren't we supposed to change the isSearchable in the list files as well?

How will that work when we start allowing folders?

So, indeed, let me explain how I see it:

Previous behaviour, before Attach project:

• we can include any single document (via list files and the conversation_include_file action)
• we can semantic search the whole conversation

New behaviour, before folders: the same.
Docs can be content nodes, but the "we can sem search the whole conversation" should work
=> this is the current PR.

New behaviour, after folders: the same:

• we can include any single document
• we can include any single folder (thus the 1 sem search action per folder)
• we can semantic search the whole convo

As for listFiles, it doesn't need an update. Content nodes doc were already marked as searchable, but since we didn't add their datasourceview in the global semantic search action, they weren't included in that search (that's what this PR solves)

[philipperolet]

we could group by datasourceview here but not sure the gain (which seems ~0 to me) is worth the added LOCs and complexity

[spolu]

New behaviour, after folders: the same:

we can include any single document
we can include any single folder (thus the 1 sem search action per folder)
we can semantic search the whole convo

When you say:

we can include any single folder (thus the 1 sem search action per folder)

It's more we can search no?

As for listFiles, it doesn't need an update. Content nodes doc were already marked as searchable, but since we didn't add their datasourceview in the global semantic search action, they weren't included in that search (that's what this PR solves)

roger that

[spolu]

LGTM

[philipperolet]

New behaviour, after folders: the same:

we can include any single document
we can include any single folder (thus the 1 sem search action per folder)
we can semantic search the whole convo

When you say:

we can include any single folder (thus the 1 sem search action per folder)

It's more we can search no?

yes, search indeed