[sparkle] - refactor(Chip): clickable Chip #11508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilities - Advanced the Chip component version to 0.2.444 to include new interactive features - Enhanced the Chip component to support both clickable and link behaviors - Adjusted the padding in size variants for improved visual consistency - Updated IconButton hover state to match the new outlined style variant - Aligned the Chip story to reflect the component's ability to handle onClick events [sparkle] - refactor: streamline Chip props and types for better clarity - Divided the ChipProps into ChipBaseProps, ChipLinkProps, and ChipButtonProps for clearer type distinction - Extracted common prop types to simplify the Chip component's interface [sparkle] - fix: IconButton outline variant hover text color - Changed the IconButton outline variant hover text color for better consistency with dark mode
JulesBelveze
force-pushed
the
sparkle/clickable-chip
branch
from
85c24fb to
0da55b3
Compare
…nent - Replace the complex type Record with a simpler type definition and clear keyof Omit construction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the Chip component to support both clickable and link behaviors
Risk
Low
Deploy Plan
Publish sparkle