Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(local dev setup): disable auto ES index creation #11505

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aubin-tchoi
Copy link
Contributor

@aubin-tchoi aubin-tchoi commented Mar 20, 2025

Description

We have observed issues with elasticsearch in local dev at several occasions.
The issue was identified a while back and was materialized as follows:

  • Calls to the search_nodes endpoint fail.
  • The index core.data_sources_nodes_4 is correctly created, but core.data_sources_nodes is not an alias that points to it, it's an index that has a mapping different from core.data_sources_nodes_4.
  • The root cause was that we tried to index documents before creating the index, letting elasticsearch create it (infers the mapping from the first document we index).

This PR addresses this issue by disabling this feature of auto-creating the index (will cause the upserts to get retried until we create the index and the alias).

Tests

  • Ongoing, will also try to find out why we don't have the alias created after running init_dev_container, which seems weird.

Risk

  • None, only affects local environment at setup time.

Deploy Plan

  • No deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant