Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table upsert] Fix: refuse empty title #11500

Merged
merged 1 commit into from
Mar 20, 2025
Merged

[Table upsert] Fix: refuse empty title #11500

merged 1 commit into from
Mar 20, 2025

Conversation

philipperolet
Copy link
Contributor

Description

Fixes e.g. this monitor

A check that title is empty before sending to upsert queue was made, but didn't trim, while the core API in upsert queue does.

Risks

low

Deploy

front

Description
---
Fixes e.g. [this monitor](https://dust4ai.slack.com/archives/C05F84CFP0E/p1742474895975459)

A check that title is empty before sending to upsert queue was made,
but didn't trim, while the core API in upsert queue does.

Risks
---
low

Deploy
---
front
@philipperolet
Copy link
Contributor Author

PMRR

Copy link
Contributor

@aubin-tchoi aubin-tchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@philipperolet philipperolet merged commit a208534 into main Mar 20, 2025
5 checks passed
@philipperolet philipperolet deleted the fix-title-empty branch March 20, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants