[front] - chore(InputBar):support slack URL pasting #11492

JulesBelveze · 2025-03-20T09:12:08Z

Description

This PR adds support for Slack URLs in the nodeIdFromUrl utility function. It now handles three types of Slack URLs:

Channel URLs: https://app.slack.com/client/TEAM_ID/CHANNEL_ID → slack-channel-CHANNEL_ID
Thread URLs: https://team.slack.com/archives/CHANNEL/TIMESTAMP?thread_ts=THREAD_TS → slack-CHANNEL-thread-THREAD_TS
Message URLs: https://team.slack.com/archives/CHANNEL/pTIMESTAMP → slack-CHANNEL-messages-YYYY-M-D-YYYY-M-D (weekly range)

Since those mime types were filtered out during search we introduce a "useCase" parameter on the search endpoint, to filter out relevant mime types depending on the use case at hand.

Risk

Low, behind FF

Deploy Plan

Deploy front

- Added a list of MIME types for nodes that cannot be pasted [front/lib/swr] - feature: support use case distinction in search parameters - Enhanced search function to differentiate between paste and search node use cases [front/pages/api] - refactor: filter search results based on use case - Implemented use case-specific exclusion of node MIME types in search results

…action - Implement URL matching and information extraction for Slack archive links - Support both thread-specific links and message links within a specific week range

… bar container - Include a new 'useCase' prop to enhance the input bar's functionality [front/lib] - refactor: streamline slack URL node ID extraction - Refactor URL node ID extraction for Slack by structuring it in individual methods - Utilize a common utility method 'getWeeklyDateRange' to calculate weekly date ranges for messages

- Removed `client_side_new_id` as it was relying on UUIDs, which are not needed anymore - Deleted `utcDateFrom` function since it's no longer being used in the codebase - Eliminated the `trimText` function to streamline the utilities available

- Implement Slack URL matching and node ID extraction for different Slack URL patterns - Extend utils with `getWeeklyDateRange` function to assist in generating Slack message node IDs [extension/ui] - refactor: include `useCase` in spaces search hook and input bar container - Pass "pasteUrl" as `useCase` to spaces search hook when used within `InputBarContainer` - Ensure the new use case parameter aligns with different usage scenarios for the search hook

- Added a new union type for `ContentNodeSearchUseCase` to handle different search scenarios - Extended `BaseSearchBodySchema` with a `useCase` field to utilize the new search use cases in requests

github-actions · 2025-03-20T09:41:29Z

	Fails
🚫	Files in `**/api/v1/` have been modified. Please add the `documentation-ack` label to acknowlegde that if anything changes in a public endpoint, you need to edit the JSDoc comment above the handler definition and/or the swagger_schemas.ts file and regenerate the documentation using `npm run docs`
🚫	Files in `/sdks/js/` have been modified. Changing the types defined in the SDK could break existing client. Additions (new types, new values) are generally fine but removals are NOT OK** : it would break the contract of the Public API. Please add the `sdk-ack` label to acknowledge that your are not breaking the existing Public API contract.

Generated by 🚫 dangerJS against f219b4c

- Removed the 'undefined' type from the useCase union in BaseSearchBody, enforcing explicit useCase specification [sdks] - fix: remove undefined type from ContentNodeSearchUseCase - Corrected the ContentNodeSearchUseCase by removing the option for it to be undefined, ensuring consistency with the API changes

- Extended search API to support a 'useCase' parameter with enum options - The new parameter helps differentiate search contexts, such as 'pasteUrl' or 'searchNode'

philipperolet

👋 We might have misunderstood each other here (no biggie)
The point when I added slack threads back into the mix was "because it was extremely simple" (I thought I had told you that, sorry if I didnt). The converse being that if it turns out not to be simple, we leave it out of the mix

The goal as per the card was only to support threads; wouldn't that have been just adding a matcher and extractor in Provider?
If yes, let's go for that. If not, let's discuss if we move forward, not sure it's worth the added complexity

Happy to discuss IRL :)

extension/shared/lib/connectors.ts

front/lib/connectors.ts

- Changed providers object keys to match ConnectorProvider type definition [front/lib] - refactor: align connector provider keys with shared definitions - Updated provider keys in the providers object to ensure consistency with shared connector naming convention

philipperolet

looks great, as discussed aro we can move forward with this PR. left a few you comments but mosty I would avoid using "useCase" and rather expose mimetypes, I think it'd be more readable avoiding creating a new abstraction

philipperolet · 2025-03-21T07:38:41Z

extension/shared/lib/connectors.ts

+    extractor: (url: URL): string | null => {
+      // Try each type of extraction in order
+      return (
+        extractChannelNodeId(url) ||


are we sure we'll never exit with a channel while there was actually a thread?

or like this is a bit tricky to read logic fast, but if we have to keep it IMO start with the most specific (thread) and end with the most general (channel)

Channel have "client" in the URL, while thread and messages have "archives", so we should be safe here 👌🏼
Will reorder checks

philipperolet · 2025-03-21T07:42:42Z

extension/shared/lib/connectors.ts

+
+// Extract a thread node ID from a Slack archives URL
+function extractThreadNodeId(url: URL): string | null {
+  const pathParts = url.pathname.split("/");


question: threads always have archive?

It seems like it yes and messages too 👍🏼

philipperolet · 2025-03-21T07:45:51Z

extension/shared/lib/utils.ts

+  return { startDate, endDate };
+}
+
+function getWeekEnd(startDate: Date): Date {


nit: a bit ricky here to have weekstart work with any date but wekend needs the weekstart while they have the same naming patttern.
would either have only one fn returning both or have both woek with any date

philipperolet · 2025-03-21T07:51:25Z

front/lib/utils.ts

@@ -9,26 +8,13 @@ export function classNames(...classes: (string | null | boolean)[]) {
  return classes.filter(Boolean).join(" ");
 }

-export function client_side_new_id() {


is that related?

Just a clean up 🧹 (saw there was a few unused functions)

- Deleted the `useCase: "pasteUrl"` property from search components and API - Removed `NON_PASTABLE_NODES_MIME_TYPES` as it's no longer needed due to the removal of the pasteUrl use case - Updated SWR hooks and API handlers to exclude the useCase parameter from their logic [sdks] - refactor: eliminate ContentNodeSearchUseCase type - Removed the `ContentNodeSearchUseCase` enum as the pasteUrl use case is no longer supported

… and input bar - Eliminated the 'useCase' property handling from useSpacesSearch hook - Removed 'useCase' from input props to simplify pasteUrl functionality - Cleaned up related effect and params in InputBarContainer to align with hook changes

- Consolidate week boundary logic into a single `getWeekBoundaries` function - Remove separate `getWeekStart` and `getWeekEnd` functions for simplification [connectors] - refactor: update usage of week boundary utilities - Replace `getWeeklyDateRange` with `getWeekBoundaries` to adhere to updated utils - Reorder extraction methods for consistency and potential performance benefits

- Recognize and handle Slack thread and message URLs with "/archives/" in the path - Identify Slack channel URLs that contain "/client/" in the pathname

philipperolet

👍 thanks!

JulesBelveze added 7 commits March 20, 2025 09:53

[front] - feature: add Slack connector for message and thread ID extr…

a6af0fa

…action - Implement URL matching and information extraction for Slack archive links - Support both thread-specific links and message links within a specific week range

rebase main

292a433

[sdks/js] - feature: support new search use cases in ContentNode search

7e2257c

- Added a new union type for `ContentNodeSearchUseCase` to handle different search scenarios - Extended `BaseSearchBodySchema` with a `useCase` field to utilize the new search use cases in requests

JulesBelveze added 3 commits March 20, 2025 11:27

fix: lint/format

6b61ebf

[front] - feature: add 'useCase' parameter to search API

8bcaf09

- Extended search API to support a 'useCase' parameter with enum options - The new parameter helps differentiate search contexts, such as 'pasteUrl' or 'searchNode'

JulesBelveze requested a review from philipperolet March 20, 2025 10:42

philipperolet reviewed Mar 20, 2025

View reviewed changes

aubin-tchoi reviewed Mar 20, 2025

View reviewed changes

extension/shared/lib/connectors.ts Show resolved Hide resolved

aubin-tchoi reviewed Mar 20, 2025

View reviewed changes

front/lib/connectors.ts Outdated Show resolved Hide resolved

JulesBelveze requested a review from philipperolet March 20, 2025 13:11

philipperolet reviewed Mar 21, 2025

View reviewed changes

JulesBelveze added 4 commits March 21, 2025 09:20

fix: lint/format

829ce50

JulesBelveze requested review from philipperolet and flvndvd March 21, 2025 08:51

[extension/shared] - feature: enhance Slack URL matching for connector

622498b

- Recognize and handle Slack thread and message URLs with "/archives/" in the path - Identify Slack channel URLs that contain "/client/" in the pathname

philipperolet approved these changes Mar 23, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[front] - chore(InputBar):support slack URL pasting #11492

[front] - chore(InputBar):support slack URL pasting #11492

JulesBelveze commented Mar 20, 2025 •

edited

Loading

github-actions bot commented Mar 20, 2025 •

edited

Loading

philipperolet left a comment

philipperolet left a comment

philipperolet Mar 21, 2025

philipperolet Mar 21, 2025

JulesBelveze Mar 21, 2025

philipperolet Mar 21, 2025

JulesBelveze Mar 21, 2025 •

edited

Loading

philipperolet Mar 21, 2025

JulesBelveze Mar 21, 2025

philipperolet Mar 21, 2025

JulesBelveze Mar 21, 2025

philipperolet left a comment

[front] - chore(InputBar):support slack URL pasting #11492

Are you sure you want to change the base?

[front] - chore(InputBar):support slack URL pasting #11492

Conversation

JulesBelveze commented Mar 20, 2025 • edited Loading

Description

Risk

Deploy Plan

github-actions bot commented Mar 20, 2025 • edited Loading

philipperolet left a comment

Choose a reason for hiding this comment

philipperolet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JulesBelveze Mar 21, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

philipperolet left a comment

Choose a reason for hiding this comment

JulesBelveze commented Mar 20, 2025 •

edited

Loading

github-actions bot commented Mar 20, 2025 •

edited

Loading

JulesBelveze Mar 21, 2025 •

edited

Loading