Fix multi-db snowflake #11485
Merged
Fix multi-db snowflake #11485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PMRR |
PopDaph
reviewed
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: https://github.com/dust-tt/tasks/issues/2402
The whole story is in the issue above but the summary is the following: there is a notion of "default" DB (I suspect the
currentflag) which is the default DB used when querying tables and schemas. If there are more than 1 DB in snowflake then querying all schemas or all tables will only pull from that DB which means that our fetchTree implementation was incorrect leading to the issues seen by the user.I checked that BigQuery is not subject to that. But Snowflake might?
Tests
N/A
Risk
Low
Deploy Plan
connectors