Remove field reasoning_content from AssistantChatMessage
#11481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5043aff.
spolu
approved these changes
Mar 19, 2025
| @@ -102,12 +102,6 @@ struct AnthropicContent { | |||
| #[serde(skip_serializing_if = "Option::is_none")] | |||
| text: Option<String>, | |||
|
|
|||
| #[serde(skip_serializing_if = "Option::is_none")] | |||
There was a problem hiding this comment.
not sure I follow that diff?
There was a problem hiding this comment.
didn't need these 2 since we never need to parse back thinking tokens from ChatMessages
There was a problem hiding this comment.
right I thought they were already gone 👍
There was a problem hiding this comment.
yy I forgot to commit on the previous PR 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
core(delimiters for Sonnet 3.5 and Deepseek R1, AFAICT not passed for o3 and o1).reasoning_contentfield fromAssistantChatMessage, which was specific to Deepseek's API (and inherited in Fireworks), and not used infront.AnthropicContent.Risk
Deploy Plan