[Google Drive] Permissions: catch ExternalOauthTokenError on oauth #11461
Conversation
Description --- Fixes logs such as [this one](https://app.datadoghq.eu/logs?query=%22Unhandled%20API%20Error%22%20status%3Aerror%20%40dd.env%3Aprod&agg_m=count&agg_m_source=base&agg_t=count&cols=host%2Cservice&event=AwAAAZWtqXqKqiOouAAAABhBWld0cVl2d0FBQ3JzdmhIcEgzVHBnQUQAAAAkMDE5NWFkYWEtM2U2NS00ZDk2LWE5ZWEtYWQ3MGI0ZTUzZTM1AAAETg&fromUser=true&messageDisplay=inline&refresh_mode=sliding&storage=hot&stream_sort=desc&viz=stream&from_ts=1714135514324&to_ts=1714136414324) ExternalOauthTokenError should be caught and not trigger an unhandled error. It is already the case for most calls, but in Google Drive retrievePermissions there was an uncaught one. Risks --- low Deploy --- connectors
There was a problem hiding this comment.
Approving as is but I wonder if would not be better to revert this change and instead move the line const authCredentials = await getAuthObject(c.connectionId); from line 250 to line 275 as first instruction of the existing try, where this error is already caught so it's centralized. WDYT?
Hadn't seen that, well spotted. Buuut... consistently bad is better than inconsistently good 😉 + less code, so going forward with your suggestion |
Description
Fixes logs such as this one
ExternalOauthTokenError should be caught and not trigger an unhandled error. It is already the case for most calls, but in Google Drive retrievePermissions there was an uncaught one.
Risks
low
Deploy
connectors