Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[front] - enh(StatusBanner): prettify component #11458

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

JulesBelveze
Copy link
Contributor

@JulesBelveze JulesBelveze commented Mar 19, 2025

Description

This PR introduces a generic StatusBanner component to standardize status banners.

Note: changes are directly ported from #11437. I created a new branch because the original one still had types/ which is a bit annoying to rebase.

Risk

Low

Deploy Plan

Deploy front

…nSidebar

 - Introduced a generic `StatusBanner` component to standardize status banners
 - Replaced duplicated banner markup with the new `StatusBanner` component for various statuses
 - Added support for a "warning" variant within the `StatusBanner` component for specific banners
@JulesBelveze JulesBelveze requested a review from PopDaph March 19, 2025 08:25
Copy link
Contributor

@PopDaph PopDaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

@JulesBelveze JulesBelveze merged commit 3ec5c87 into main Mar 19, 2025
7 checks passed
@JulesBelveze JulesBelveze deleted the front/enh-status-banner branch March 19, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants