[Conversations - Fragment] Return 400 on image format not supported #11451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description --- Fixes issue from thread [here](), so there is no unhandled api error. Receiving a 3rd party message "Image format not supported", an unhandled api error is not warranted since not actionable by us. The best is to throw a 400. Risks --- low Deploy --- front
|
philipperolet
added
the
documentation-ack
|
PMRR |
spolu
approved these changes
Mar 18, 2025
flvndvd
reviewed
Mar 18, 2025
| @@ -58,8 +61,10 @@ export async function toFileContentFragment( | |||
|
|
|||
| if (processRes.isErr()) { | |||
| return new Err({ | |||
There was a problem hiding this comment.
Can we avoid raw object as error 🙏 ?
There was a problem hiding this comment.
In this case, unfortunately, no, or it would require too much work to make old code consistent, change the DustError type from which ProcessAndStoreFileError is derived, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue from thread here, so there is no unhandled api error.
Receiving a 3rd party message "Image format not supported", an unhandled api error is not warranted since not actionable by us. The best is to throw a 400.
Risks
low
Deploy
front