-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[front] - fix(TablePicker): infinite scroll #11446
Merged
+534
−44
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
20572bb
[front/hooks] - feature: implement cursor pagination hook
JulesBelveze df18cca
[front/lib/swr] - feature: implement pagination and search in data so…
JulesBelveze 4be200c
[front/api/w/spaces/data_source_views/tables] - feature: paginate tab…
JulesBelveze 7a01634
[front/components/tables] - feature: enhance TablePicker with paginat…
JulesBelveze 31a0830
[front/api] - fix: adjust datasource access control and refine tests
JulesBelveze c1e15d3
fix: lint/format
JulesBelveze cab1239
[front] - test: temporarily skip failing tests for CoreAPI.searchNode…
JulesBelveze 7367c5e
[front] - refactor: increase table picker page size to 25
JulesBelveze f255cb7
[front] - refactor: switch TablePicker allTables to use Map for bette…
JulesBelveze b438c13
[front] - refactor: Update TablePicker to overwrite existing tables
JulesBelveze File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[front] - refactor: switch TablePicker allTables to use Map for bette…
…r efficiency - Changed the state structure from an array to a Map to optimize table lookups and avoid duplicates - Updated the useEffect to handle pagination logic using the new Map, improving performance with large table lists - Modified rendering logic to convert the Map to an array for display and filter operations
commit f255cb7108ba57dc63cef96d1941384ff3f6d487
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you really need the test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair ✅