Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Gong) - correctly handle empty string as a retention period #11443

Merged
merged 1 commit into from
Mar 18, 2025
Merged

fix(Gong) - correctly handle empty string as a retention period #11443

merged 1 commit into from
Mar 18, 2025

Conversation

aubin-tchoi
Copy link
Contributor

Description

  • Fix handling of "" in GongConnectorManager's setConfigurationKey.

Tests

  • Tested locally.

Risk

  • N/A.

Deploy Plan

  • Deploy connectors.

@aubin-tchoi aubin-tchoi requested a review from albandum March 18, 2025 13:29
albandum
albandum approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@albandum albandum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aubin-tchoi aubin-tchoi merged commit f5a38eb into main Mar 18, 2025
6 checks passed
@aubin-tchoi aubin-tchoi deleted the fix-gong-set-ret branch March 18, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albandum albandum albandum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aubin-tchoi @albandum