Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salesforce enabled per plan #11440

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Salesforce enabled per plan #11440

merged 1 commit into from
Mar 19, 2025

Conversation

PopDaph
Copy link
Contributor

@PopDaph PopDaph commented Mar 18, 2025

Description

Adds isSalesforceAllowed to plan following the logic we have for other connectors.
We do not call it yet on isConnectorProviderAllowedForPlan (cf comment in code) so that I can properly deploy it.

Tests

Locally.

Risk

Can be rolled back - the new column has a default value and there has not many entries.

Deploy Plan

  • Merge
  • Run front migration
  • Deploy
  • Activate the flag for desired plans.
  • Do a second PR to update isConnectorProviderAllowedForPlan

@PopDaph PopDaph added the migration-ack 📁 Label to acknowledge that a migration is required. label Mar 18, 2025
Copy link

Warnings
⚠️

Files in **/lib/models/ have been modified and the PR has the migration-ack label. Don't forget to run the migration from prodbox.

Generated by 🚫 dangerJS against 7acefab

@PopDaph PopDaph requested a review from tdraier March 18, 2025 12:32
@PopDaph PopDaph merged commit a910b2f into main Mar 19, 2025
8 checks passed
@PopDaph PopDaph deleted the plan-salesforce branch March 19, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration-ack 📁 Label to acknowledge that a migration is required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants