fix(`api/v1`) - Add trimming on title in tags #11432

aubin-tchoi · 2025-03-18T10:26:12Z

Description

Follow up on enh(api/v1) - Trim titles on upserts to fallback correctly on "Untitled document" #11422.
Context here.
A google drive document is stuck in the upsert queue due to having an empty title.
We get a the following title from Google's API: " ", we then pass it in the tags, where it is read and passed as is to the upsert-queue document.
This PR adds trimming on the title found in the tags.

github-actions · 2025-03-18T10:27:58Z

	Warnings
⚠️	Files in `**/api/v1/` have been modified and the PR has the `documentation-ack` label. Don't forget to run `npm run docs` and use the `Deploy OpenAPI Docs` Github action to update https://docs.dust.tt/reference.

Generated by 🚫 dangerJS against 21359ab

flvndvd · 2025-03-18T10:30:44Z

front/pages/api/v1/w/[wId]/spaces/[spaceId]/data_sources/[dsId]/tables/index.ts

@@ -317,7 +317,8 @@ async function handler(
      // - the name of the table
      const titleInTags = tags


nit but a helper here would avoid this duplicated code.

merging as it but I had planned to consolidate the validation + this part in common utils

fix trimming on title in tags

21359ab

aubin-tchoi requested a review from flvndvd March 18, 2025 10:26

aubin-tchoi added the documentation-ack Used to acknowledge that documentation is up-to-date with this PR label Mar 18, 2025

flvndvd approved these changes Mar 18, 2025

View reviewed changes

aubin-tchoi merged commit 36b5fba into main Mar 18, 2025
9 checks passed

aubin-tchoi deleted the fix-trimming branch March 18, 2025 10:34

flvndvd mentioned this pull request Mar 18, 2025

Remove Intercom try/catch #11444

Merged