Skip to content

fix danger to include created and deleted files #11428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

fix danger to include created and deleted files #11428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions front/dangerfile.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,13 @@ function warnDocumentationAck(documentationAckLabel: string) {
);
}

function checkModifiedFiles() {
const modifiedModelFiles = danger.git.modified_files.filter((path) => {
function checkDiffFiles() {
const diffFiles = danger.git.modified_files
.concat(danger.git.created_files)
.concat(danger.git.deleted_files);

// Model files
const modifiedModelFiles = diffFiles.filter((path) => {
return (
path.startsWith("front/lib/models/") ||
path.startsWith("front/lib/resources/storage/models/") ||
Expand All @@ -130,23 +135,26 @@ function checkModifiedFiles() {
checkDeployPlanSection();
}

const modifiedPublicApiFiles = danger.git.modified_files.filter((path) => {
// Public API files
const modifiedPublicApiFiles = diffFiles.filter((path) => {
return path.startsWith("front/pages/api/v1/");
});

if (modifiedPublicApiFiles.length > 0) {
checkDocumentationLabel();
}

const modifiedAuth0Files = danger.git.modified_files.filter((path) => {
// Auth0 files
const modifiedAuth0Files = diffFiles.filter((path) => {
return path.startsWith("front/lib/utils/blacklisted_email_domains.ts");
});

if (modifiedAuth0Files.length > 0) {
checkAuth0UpdateLabel();
}

const modifiedSdksFiles = danger.git.modified_files.filter((path) => {
// SDK files
const modifiedSdksFiles = diffFiles.filter((path) => {
return path.startsWith("sdks/js/");
});

Expand All @@ -155,4 +163,4 @@ function checkModifiedFiles() {
}
}

checkModifiedFiles();
checkDiffFiles();