Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API v1 - Conversations] Require non-empty user messages #11423

Merged
merged 4 commits into from
Mar 24, 2025

Conversation

philipperolet
Copy link
Contributor

@philipperolet philipperolet commented Mar 17, 2025

Description

Fixes https://github.com/dust-tt/tasks/issues/2123 (see also slack thread in issue)

Reverts #10650 . Throws 400 if empty string is passed as message

Risks

We are slightly changing the API v1 contract.

Risk: pissed off clients that used to send empty messages to non-anthropic clients and don't want to send " " instead.

Also, if we ever send empty messages internally, we'll soon know (but doubt we do, there's always the mention at least)

Deploy

  • warn spendesk
  • warn customer success team & user runner
  • deploy front

@philipperolet philipperolet requested a review from spolu March 17, 2025 21:04
Copy link

github-actions bot commented Mar 17, 2025

Warnings
⚠️

Files in **/api/v1/ have been modified and the PR has the documentation-ack label.
Don't forget to run npm run docs and use the Deploy OpenAPI Docs Github action to update https://docs.dust.tt/reference.

Generated by 🚫 dangerJS against 0b15311

@philipperolet philipperolet added documentation-ack Used to acknowledge that documentation is up-to-date with this PR sdk-ack Used to acknowledge that you are not breaking the public API. labels Mar 17, 2025
Copy link
Contributor

@spolu spolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fraggle
Copy link
Contributor

Fraggle commented Mar 18, 2025

@philipperolet can we update the front end to avoid allowing to send an empty message (It happens all the time to me)

@philipperolet
Copy link
Contributor Author

in the frontend we can't send an empty message already, since we have the mention. If we did, as per the PR, this would fail yes.

@philipperolet philipperolet merged commit 266f69d into main Mar 24, 2025
8 checks passed
@philipperolet philipperolet deleted the fix-400-emptymsg branch March 24, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation-ack Used to acknowledge that documentation is up-to-date with this PR sdk-ack Used to acknowledge that you are not breaking the public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants