Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(Poke) - Add a column "Kind" to DataSourceViewsDataTable #11420

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

aubin-tchoi
Copy link
Contributor

Description

  • When debugging pages that are not found in Notion, we often need to compare the permissions tree (poke data source) to the data source view tree (poke default data source view).
  • This PR simplifies this process by adding a column to show the data source view kind.
  • This is not reasonable readable for non-eng as is, the key information here is that kind = default means that it's everything that was selected, as the user can see when adding it to a Space.

Tests

  • Checked locally.

Risk

  • N/A.

Deploy Plan

  • Deploy front.

@aubin-tchoi aubin-tchoi requested a review from flvndvd March 17, 2025 17:57
@aubin-tchoi aubin-tchoi merged commit 7ec1f7c into main Mar 18, 2025
9 checks passed
@aubin-tchoi aubin-tchoi deleted the show-dsv-kind-poke branch March 18, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants