[core] Fix 'filterable' info in field schema #11418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdraier
changed the title
flvndvd
approved these changes
Mar 18, 2025
| @@ -405,6 +405,10 @@ impl SalesforceRemoteDatabase { | |||
| QueryDatabaseError::GenericError(anyhow!("Field `soapType` not found")) | |||
| })?; | |||
|
|
|||
| let filterable = field["filterable"].as_bool().ok_or_else(|| { | |||
There was a problem hiding this comment.
Feels weird to have the payload different from what we save in DB.
tdraier
deleted the
revert-11415-revert-11408-thomas/block-non-queriable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #11415 and restore #11408
Now use an optional for non_filterable so that json deserialization does not crash when stored schema does / does not contain "non_filterable"
We have a few entries in db with "filterable:true", but these are safely ignored when deserializing, and will eventually be replaced when reupserting the table.