-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSO User Deduplication Plugin #11404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ssoMembership.user?.id | ||
); | ||
if (!ssoUser) { | ||
continue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we could want to know that the even in dry mode
} | ||
|
||
// Find oldest user (excluding SSO user). | ||
const oldestMembership = dupes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: do we want to be informed if there are more than 1 other membership? There could be a case where for some reason we have 2 other ones and the auth0 sub is put on the wrong one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could push it in changes, but here we make the assumptions that it can exist and the script on purpose ignores it.
* Add Poke plugin to merge duplicated users from SSO * ✏️ * ✨
Description
This PR adds a Poke plugin that handles duplicate user accounts created when SSO is enabled for a workspace. The plugin focuses on access consolidation rather than content migration.
🚗 also fixed https://github.com/dust-tt/tasks/issues/2400.
Plugin Behavior
For each email with duplicate active memberships in a workspace:
Safety Features
Example Output (Dry Run)
Tests
Risk
Deploy Plan