[Attach] Clean hotfix from #11385 #11403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flvndvd
approved these changes
Mar 17, 2025
| fileId: -1, | ||
| nodeId: null, | ||
| nodeDataSourceViewId: null, | ||
| // At time of writing, passe resourceId can be either a file or a content fragment. |
There was a problem hiding this comment.
Suggested change
| // At time of writing, passe resourceId can be either a file or a content fragment. | |
| // At time of writing, passed resourceId can be either a file or a content fragment. |
Description --- Follows #11385 which was a hotfix. Makes change clean, durable. For reviewer: - only 1 file to really review, `content_fragment_resource.ts` - rest is a parameter renaming Related conversation [here](https://dust4ai.slack.com/archives/C050SM8NSPK/p1742205905623529) Risks --- low Deploy --- front
philipperolet
force-pushed
the
clean-file-inclusion
branch
from
e2669f6 to
df188a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follows #11385 which was a hotfix. Makes change clean, durable.
For reviewer:
content_fragment_resource.tsRelated conversation here
Risks
low
Deploy
front