Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] replace parse_duration crate #11398

Merged
merged 1 commit into from
Mar 17, 2025
Merged

[core] replace parse_duration crate #11398

merged 1 commit into from
Mar 17, 2025

Conversation

tdraier
Copy link
Contributor

@tdraier tdraier commented Mar 17, 2025

Description

Replace with humantime , which is much more widely used and no vulnerability identified

Tests

Risk

Deploy Plan

deploy core

@tdraier tdraier requested a review from spolu March 17, 2025 09:42
spolu
spolu approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@spolu spolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tdraier tdraier merged commit 9fb0e86 into main Mar 17, 2025
5 checks passed
@tdraier tdraier deleted the thomas/parse-duration branch March 17, 2025 10:01
frankaloia pushed a commit that referenced this pull request Mar 17, 2025
@tdraier @frankaloia
[core] Replace parse_duration crate (#11398)
2cd01ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spolu spolu spolu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdraier @spolu