Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: move actions type within actions #11388

Merged
merged 1 commit into from
Mar 15, 2025
Merged

Refactor: move actions type within actions #11388

merged 1 commit into from
Mar 15, 2025

Conversation

Fraggle
Copy link
Contributor

@Fraggle Fraggle commented Mar 15, 2025 •
edited
Loading

Description

On my way to simplify action types, moved front/types/assistants/actions/* to front/lib/actions/types.

Tests

tsc + green + locally

Risk

Low

Deploy Plan

Deploy front and check monitors

@Fraggle Fraggle requested review from spolu and flvndvd March 15, 2025 06:53
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 15, 2025 •
edited
Loading

Warnings
⚠️

Files in **/lib/models/ have been modified and the PR has the migration-ack label. Don't forget to run the migration from prodbox.

Generated by 🚫 dangerJS against 08b2cc9

@Fraggle Fraggle added the migration-ack 📁 Label to acknowledge that a migration is required. label Mar 15, 2025
@Fraggle Fraggle merged commit 79cc0ba into main Mar 15, 2025
9 checks passed
@Fraggle Fraggle deleted the sflory-simplify-actions-types branch March 15, 2025 07:01
flvndvd
flvndvd reviewed Mar 15, 2025
View reviewed changes
Copy link
Contributor

@flvndvd flvndvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

spolu
spolu reviewed Mar 15, 2025
View reviewed changes
Copy link
Contributor

@spolu spolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niice

frankaloia pushed a commit that referenced this pull request Mar 17, 2025
@Fraggle @frankaloia
Refactor: move actions type within actions (#11388)
fed850c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spolu spolu spolu left review comments

@flvndvd flvndvd flvndvd left review comments

Assignees
No one assigned
Labels
migration-ack 📁 Label to acknowledge that a migration is required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fraggle @spolu @flvndvd