feat(Gong) - allow setting the retention period in GongOptionComponent
#11384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aubin-tchoi
force-pushed
the
gong-retention-policy-ui
branch
from
5a836d7 to
10edcc4
Compare
JulesBelveze
approved these changes
Mar 17, 2025
Contributor
JulesBelveze
left a comment
JulesBelveze
left a comment
There was a problem hiding this comment.
LGTM, left a few nits.
Could we add a screenshot? 🙏🏼
| isAdmin: boolean; | ||
| dataSource: DataSourceType; | ||
| }) { | ||
| const configKey = "gongRetentionPeriodDays"; |
Contributor
There was a problem hiding this comment.
nit: Let's extract a global var?
Comment on lines
+24
to
+27
| owner: WorkspaceType; | ||
| readOnly: boolean; | ||
| isAdmin: boolean; | ||
| dataSource: DataSourceType; |
Contributor
There was a problem hiding this comment.
Let's extract everything as an interface ? 🙏🏼
| import { useConnectorConfig } from "@app/lib/swr/connectors"; | ||
|
|
||
| function checkIsPositiveInteger(value: string) { | ||
| return /^[0-9]+$/.test(value); |
Contributor
There was a problem hiding this comment.
Noob question: any reason for a regex over a parseInt + inequality?
Contributor
Author
There was a problem hiding this comment.
not really, we can def do a parseInt + inequality 👍
Contributor
Author
There was a problem hiding this comment.
actually parseInt is less restrictive, keeping the regex
> parseInt("123abc", 10);
123
frankaloia
pushed a commit
that referenced
this pull request
Mar 17, 2025
…nt` (#11384) * add an Input to update the retention period * fix: update imports to use @app/types instead of the deprecated @dust-tt/types * add a global variable for RETENTION_PERIOD_CONFIG_KEY * rename the global variable * add an interface GongOptionComponentProps * replace regex check with parseInt + inequality * rename checkIsPositiveInteger into checkIsNonNegativeInteger since 0 is allowed * Revert "rename checkIsPositiveInteger into checkIsNonNegativeInteger since 0 is allowed" This reverts commit 4d59803. * Revert "replace regex check with parseInt + inequality" This reverts commit 5c79fab. * rename checkIsPositiveInteger into checkIsNonNegativeInteger since 0 is allowed
pinotalexandre
pushed a commit
that referenced
this pull request
Apr 30, 2025
…nt` (#11384) * add an Input to update the retention period * fix: update imports to use @app/types instead of the deprecated @dust-tt/types * add a global variable for RETENTION_PERIOD_CONFIG_KEY * rename the global variable * add an interface GongOptionComponentProps * replace regex check with parseInt + inequality * rename checkIsPositiveInteger into checkIsNonNegativeInteger since 0 is allowed * Revert "rename checkIsPositiveInteger into checkIsNonNegativeInteger since 0 is allowed" This reverts commit 4d59803. * Revert "replace regex check with parseInt + inequality" This reverts commit 5c79fab. * rename checkIsPositiveInteger into checkIsNonNegativeInteger since 0 is allowed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GongOptionComponentto allow setting the desired retention period (in number of days).setConfigurationKeyto update the retention period (backend already implemented).Tests
Risk
Deploy Plan