Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup transcripts front code + make Gong processing use the native connector's oAuth connection #11317

Merged
merged 24 commits into from
Mar 18, 2025

Conversation

albandum
Copy link
Contributor

@albandum albandum commented Mar 11, 2025

Description:

This PR adds support for connecting Gong as a transcripts provider through the connector system and refactors the transcripts processing feature for better maintainability.

Key changes:

  • Added support for Gong connector integration through useConnectorConnection flag
  • Split transcript configuration UI into separate reusable components:
    • DeleteProviderDialog for provider disconnection
    • ProcessingConfiguration for agent and email processing settings
    • ProviderSelection for provider connection management
    • StorageConfiguration for transcript storage settings
  • Added new database migration to support connector-based configurations
  • Improved error handling and user feedback
  • Refactored Gong access token retrieval to support both direct OAuth and connector-based authentication

The changes improve the architecture by:

  • Separating concerns into dedicated components
  • Making the code more maintainable and testable
  • Providing a consistent user experience across different provider types
  • Supporting both OAuth and connector-based authentication methods

Deploy plan

Apply migration 179
Deploy
Apply migration 180

@albandum albandum marked this pull request as ready for review March 12, 2025 17:14
@albandum albandum changed the title Alban/gong with connector Cleanup transcripts front code + make Gong processing use the native connector's oAuth connection Mar 12, 2025
Copy link

github-actions bot commented Mar 12, 2025

Fails
🚫 Please include a detailed Deploy Plan section in your PR description.
Warnings
⚠️

Files in **/lib/models/ have been modified and the PR has the migration-ack label. Don't forget to run the migration from prodbox.

Generated by 🚫 dangerJS against 5904843

@albandum albandum requested a review from flvndvd March 12, 2025 17:19
@albandum albandum force-pushed the alban/gongWithConnector branch from 65cdee6 to f07235d Compare March 13, 2025 08:38
@albandum albandum added the migration-ack 📁 Label to acknowledge that a migration is required. label Mar 13, 2025
@albandum albandum requested a review from flvndvd March 14, 2025 10:12
Copy link
Contributor

@flvndvd flvndvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Well done on the refactoring, it's 10x cleaner 👏 !

);
let bodyToParse = req.body;

if (typeof req.body === "string") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels weird that you need this 🤔. We enable body parsing at the Next level.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it does, but I had to add it to make it work 🤔

@albandum albandum added the sdk-ack Used to acknowledge that you are not breaking the public API. label Mar 18, 2025
@albandum albandum merged commit 0421631 into main Mar 18, 2025
5 of 6 checks passed
@albandum albandum deleted the alban/gongWithConnector branch March 18, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration-ack 📁 Label to acknowledge that a migration is required. sdk-ack Used to acknowledge that you are not breaking the public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants