-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup transcripts front code + make Gong processing use the native connector's oAuth connection #11317
Conversation
…e front use it for Gong correctly. Last step is to get the temporal activity to use this
65cdee6
to
f07235d
Compare
usecall back + few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Well done on the refactoring, it's 10x cleaner 👏 !
); | ||
let bodyToParse = req.body; | ||
|
||
if (typeof req.body === "string") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels weird that you need this 🤔. We enable body parsing at the Next level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it does, but I had to add it to make it work 🤔
Description:
This PR adds support for connecting Gong as a transcripts provider through the connector system and refactors the transcripts processing feature for better maintainability.
Key changes:
useConnectorConnection
flagDeleteProviderDialog
for provider disconnectionProcessingConfiguration
for agent and email processing settingsProviderSelection
for provider connection managementStorageConfiguration
for transcript storage settingsThe changes improve the architecture by:
Deploy plan
Apply migration 179
Deploy
Apply migration 180