0.4.2: bugfix

fix missing NProgress.done() when request failed.
duoshuo · Aug 14, 2014 · f89c1d0 · f89c1d0
1 parent a0a0939
commit f89c1d0
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 5 deletions.
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "duoshuo",
-  "version": "0.4.1",
+  "version": "0.4.2",
   "authors": [
     "turing <[email protected]>"
   ],

diff --git a/dist/duoshuo.min.js b/dist/duoshuo.min.js
diff --git a/dist/duoshuo.min.js.map b/dist/duoshuo.min.js.map
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "angular-duoshuo",
-  "version": "0.4.1",
+  "version": "0.4.2",
   "description": "a duoshuo SDK for angular.js, pure front-end, cross-domain request supported.",
   "main": "dist/duoshuo.min.js",
   "scripts": {

diff --git a/src/duoshuo.js b/src/duoshuo.js
@@ -25,7 +25,13 @@
           );
           if (!skipCheck) $rootScope.$apply();
           return;
-        }, errorCallback);
+        }, function(err) {
+          if (NProgressExist) NProgress.done();
+          if (errorCallback && typeof(errorCallback) === 'function') {
+            return errorCallback(err);
+          }
+          return;
+        });
       }
     });