Bugfix: fix dynamic params render in ds-thread

duoshuo · Jan 9, 2015 · ea9cb4a · ea9cb4a
1 parent 5817839
commit ea9cb4a
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 9 deletions.
diff --git a/bower.json b/bower.json
@@ -1,6 +1,5 @@
 {
   "name": "duoshuo",
-  "version": "0.5.0",
   "authors": [
     "turing <[email protected]>"
   ],

diff --git a/dist/duoshuo.min.js b/dist/duoshuo.min.js
diff --git a/dist/duoshuo.min.js.map b/dist/duoshuo.min.js.map
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "angular-duoshuo",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "description": "a duoshuo SDK for angular.js, pure front-end, cross-domain request supported.",
   "main": "dist/duoshuo.min.js",
   "scripts": {

diff --git a/src/duoshuo.js b/src/duoshuo.js
@@ -102,18 +102,43 @@
   }
 
   function createDirective(type) {
+    if (type === 'ds-thread') {
+      return function dsThreadDirective() {
+        return {
+          restrict: 'AE',
+          replace: true,
+          template: '<div class="ds-thread-wrapper"></div>',
+          link: function(scope, element, attrs) {
+            // Render comments when DOM has been injected.
+            angular.element(document).ready(function() {
+              var data = {};
+              if (attrs.threadId) data['thread-id'] = attrs.threadId;
+              if (attrs.threadKey) data['thread-key'] = attrs.threadKey;
+
+              // Fired after DOM ready
+              angular
+                .element(element[0])
+                .append(window.DUOSHUO.createEmbedThread('div', data));
+            });
+          }
+        };
+      };
+    }
+
     return function directive() {
       return {
         restrict: 'AE',
         replace: true,
         template: '<div class="' + type + '">',
         link: function(scope, element, attrs) {
-          if (!window.DUOSHUO || !window.DUOSHUO.initSelector)
-            return;
+          angular.element(document).ready(function() {
+            if (!window.DUOSHUO || !window.DUOSHUO.initSelector)
+              return;
 
-          // Trigger init selector function 
-          window.DUOSHUO
-            .initSelector(window.DUOSHUO.selectors['.' + type])
+            // Trigger init selector function 
+            window.DUOSHUO
+              .initSelector(type, window.DUOSHUO.selectors['.' + type])
+          });
         }
       };
     }