Origin/local #3
Open
Origin/local #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agawande
reviewed
Jun 5, 2020
| #include <list> | ||
| #include <iostream> | ||
|
|
||
| // #include <list> |
agawande
reviewed
Jun 5, 2020
| @@ -225,13 +211,11 @@ ServiceDiscovery::sendData(const ndn::Name& name) | |||
| auto timeDiff = ndn::time::system_clock::now() - m_producerState.publishTimestamp; | |||
| auto timeToExpire = ndn::time::duration_cast<ndn::time::seconds>(timeDiff); | |||
|
|
|||
| int status = (timeToExpire > m_producerState.serviceLifetime) ? EXPIRED : ACTIVE; | |||
| m_serviceStatus = (timeToExpire > m_producerState.serviceLifetime) ? EXPIRED : ACTIVE; | |||
There was a problem hiding this comment.
Move lines 211-214 to wireEncode too.
And you need to still have a local variable serviceStatus
and then check with global variable. Otherwise no need to wireEncode again.
agawande
reviewed
Jun 5, 2020
| totalLength += encoder.prependVarNumber(totalLength); | ||
| totalLength += encoder.prependVarNumber(tlv::DiscoveryData); | ||
|
|
||
| return totalLength; | ||
| } | ||
|
|
||
| const ndn::Block& | ||
| ServiceDiscovery::wireEncode(const std::string& info, int status) | ||
| ServiceDiscovery::wireEncode() | ||
| { | ||
| if (m_wire.hasWire()) |
There was a problem hiding this comment.
If hasWire, you should simply resend. The below string should be saved in a class member and then reset wire when this string is modified/updated.
agawande
reviewed
Jun 5, 2020
| @@ -375,19 +384,17 @@ ServiceDiscovery::wireDecode(const ndn::Block& wire) | |||
| } | |||
|
|
|||
| wire.parse(); | |||
| m_wire = wire; | |||
| ndn::Block::element_const_iterator it = wire.elements_begin(); | |||
agawande
reviewed
Jun 5, 2020
There was a problem hiding this comment.
Still don't understand why pFlags are passed as std::map<char, uint8_t> instead of something like:
https://github.com/named-data/ndn-cxx/blob/master/ndn-cxx/util/segment-fetcher.hpp#L114
(ctor: https://github.com/named-data/ndn-cxx/blob/master/ndn-cxx/util/segment-fetcher.hpp#L164)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.