Skip to content

Commit

Permalink
Remove harmful wording (#2670)
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathanKingston authored Jan 22, 2025
1 parent 30a33f7 commit f0acfa7
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tests/config-tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ describe('Config schema tests', () => {
});

it('all features should be named correctly', () => {
const grandfatheredFeatures = [
const legacyFeatures = [
'androidBrowserConfig',
'androidNewStateKillSwitch',
'windowsDownloadLink',
Expand All @@ -61,7 +61,7 @@ describe('Config schema tests', () => {
for (const featureName of Object.keys(config.body.features)) {
expect(featureName).to.match(featureNameRegex);
// Features should not have platform specific names so we can use the same config for all platforms.
if (!grandfatheredFeatures.includes(featureName)) {
if (!legacyFeatures.includes(featureName)) {
expect(featureName).to.not.match(deviceSpecificCheck);
}

Expand All @@ -78,9 +78,9 @@ describe('Config schema tests', () => {

it('All features should have a corresponding feature file', () => {
// Note: We should not add more to this list, only remove
const grandfatheredFeatures = ['webViewBlobDownload', 'experimentTest', 'eme', 'clientContentFeatures'];
const legacyFeatures = ['webViewBlobDownload', 'experimentTest', 'eme', 'clientContentFeatures'];
for (const featureName of Object.keys(config.body.features)) {
if (grandfatheredFeatures.includes(featureName)) {
if (legacyFeatures.includes(featureName)) {
continue;
}
const dasherizedFeatureName = featureName.replace(/([a-z0-9])([A-Z0-9])/g, '$1-$2').toLowerCase();
Expand Down

0 comments on commit f0acfa7

Please sign in to comment.