Skip to content

Commit

Permalink
Added variants and feature for notificationPermissions experiment (#1771
Browse files Browse the repository at this point in the history
)

* Added variants and feature for notificationPermissions experiment

* Enable experiment feature

* Added new feature to features directory

* Changed new feature json file for consistency
  • Loading branch information
nalcalag authored Jan 30, 2024
1 parent 2c85c88 commit bd1e7db
Show file tree
Hide file tree
Showing 3 changed files with 38 additions and 1 deletion.
7 changes: 7 additions & 0 deletions features/notification-permissions.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"_meta": {
"description": "Notification permissions prompt feature. Allow us to show/hide prompt in onboarding",
"sampleExcludeRecords": {}
},
"exceptions": []
}
3 changes: 2 additions & 1 deletion index.js
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ const excludedFeaturesFromUnprotectedTempExceptions = [
'windowsWaitlist',
'windowsDownloadLink',
'dbp',
'sync'
'sync',
'notificationPermissions'
]
function applyGlobalUnprotectedTempExceptionsToFeatures (key, baseConfig, globalExceptions) {
if (!excludedFeaturesFromUnprotectedTempExceptions.includes(key)) {
Expand Down
29 changes: 29 additions & 0 deletions overrides/android-override.json
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,19 @@
}
}
},
"notificationPermissions": {
"state": "enabled",
"features": {
"noPermissionsPrompt": {
"state": "enabled",
"targets": [
{
"variantKey": "mg"
}
]
}
}
},
"requestFilterer": {
"state": "enabled",
"minSupportedVersion": 51501000,
Expand Down Expand Up @@ -567,6 +580,22 @@
"desc": "this is SERP don't remove",
"variantKey": "se",
"weight": 0.0
},
{
"desc": "Control group for notification permissions experiment",
"variantKey": "mf",
"weight": 0.0,
"filters": {
"androidVersion": ["34", "33"]
}
},
{
"desc": "No notifications permissions prompt experimental group",
"variantKey": "mg",
"weight": 0.0,
"filters": {
"androidVersion": ["34", "33"]
}
}
]
}
Expand Down

0 comments on commit bd1e7db

Please sign in to comment.