Ensure the Playwright route handler is set up early enough #3366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzar
force-pushed
the
firefox-playwright-03
branch
from
41a6335 to
6127f11
Compare
Tests were sometimes timing out, waiting for `background.forAllConfiguration()` to resolve. It turned out, that occasionally the request for the HTTPS bloom filter would start before the route handler could be set up, which resulted in the request sometimes failing and therefore `https.isReady` to remain false. Let's set up the route handler as soon as possible, to avoid that from happening.
kzar
force-pushed
the
firefox-playwright-03
branch
from
6127f11 to
e25cddd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were sometimes timing out, waiting for
background.forAllConfiguration()to resolve. It turned out, that occasionally the request for the HTTPS bloom
filter would start before the route handler could be set up, which resulted in
the request sometimes failing and therefore
https.isReadyto remain false.Let's set up the route handler as soon as possible, to avoid that from
happening.