-
Notifications
You must be signed in to change notification settings - Fork 173
Translate duckduckgo to he_IL #773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@GioSensation Sorry to bother you with this but I’ve seen that you were active in this repo in the past. I just have no idea who else could help me with this matter.. Do you by any chance know what is the process of approving a community translation? I could take care of the conflicts but I’m starting to think that perhaps @duckduckgo is not really keen to get help from the community with translations. Hopefully I’m wrong.. |
| #. Tells the user where to click in their browser. Part of a list of instructions on how to change the brower's home page. | ||
| msgid "Enter %shttps://duckduckgo.com%s" | ||
| msgstr "הכנסו ל-%shttps://duckduckgo.com%s" | ||
| msgstr "הזן %shttps://duckduckgo.com%s" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for typing into a field, so I guess the previous version was more correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The verb הזן means to type, while הכנסו ל means go to.
Since this string is used to instruct people to type a web address and not to go to a website, I think my version is more correct.
|
|
||
| #. The name of the Fijian language | ||
| msgctxt "language_name" | ||
| msgid "Fijian" | ||
| msgstr "" | ||
| msgstr "פיג'ית" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double checking. Is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the Hebrew Wikipedia page of Fiji as a reference. It lists פיג׳ית (transliteration is Fijit) as one of the official languages.
I haven’t been able to find a more reputable source sadly.
|
|
||
| # Translator note: Is this a proper noun? Should it be translated? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to translate. Leave it blank as it is.
|
Thanks, @codokie. I've left just a couple of comments, but I will leave it to my colleague @thisisrajat to complete the review. FYI, I've seen quite a few deleted strings like this. Please make sure you revert those. And note that any change in the source string (you mentioned typos, etc.) will be overwritten and ignored, so please do not change any source string. |
|
Thank you @GioSensation for taking the time to start a review of my translation. I understand it’s not an easy task when considering the amount of changes. I’ll try to be patient throughout the review process, although I do really hope it would be merged eventually in the not too far future.
That is completely unintentional, it must be a processing bug of the tool called GTranslator which I’ve used. I’ll revert any change to the source strings. Thanks for telling me about this error!
When I mentioned typos, I meant typos in the Hebrew translation only. I did not find any typo with the source strings. Sorry about the misunderstanding. |
|
Okay I’ve added all the strings that were absent. It likely was due to a bad git merge, so not Gtranslator’s fault. I’ve also translated the new strings from the past 4 months, and made very few corrections to my old translation. It’s now ready for review. Any feedback from anyone is appreciated. |
Thank you for fixing that! I'll start reviewing this, but please bear with me as this is a big change, which we really appreciate! That said, I'll definitely get this merged. |
|
I just found out about Unicode bidi support and I’m now curious if translated strings may contain Unicode characters. If so, I could embed directional formatting characters to ensure correct text rendering even without proper RTL support. |
Some remarks about the translation:
Translator note:. It would be great to get a clarification.