Skip to content

Conversation

@codokie
Copy link

@codokie codokie commented Apr 11, 2025

Some remarks about the translation:

  • Translated strings containing both Hebrew and English will not be rendered properly due to lack of RTL text direction support (related issue: RTL Style support  duckduckgo-styles#73). This obviously affects the current (partial) translation as well. I cannot emphasize enough how crucial this is for RTL script locales, including Arabic!
  • Most of the translations are not gender-neutral and assume the user is male, as making them gender-neutral would necessitate altering the meaning or structure of certain sentences, resulting in a cluttered appearance or impersonal prompts.
  • Browser-specific instructions may not accurately represent the source, as most such strings do not specify the type of browser for which the instructions are intended.
  • Some abbreviations have been left out or expanded because the phrases they represent are not well-known or usually abbreviated in Hebrew.
  • I could not understand the context of a few strings so I left a comment, prefixed with Translator note:. It would be great to get a clarification.
  • There may be typos and such, please let me know if you find any. I've reviewed the translation twice and utilized machine translations when in doubt, but I'm no professional so there could still be mistakes/inconsistencies. That said, there were over a dozen of mistakes in the original translation which I corrected, so you may want to take this into account when doing a quality assessment.

@codokie
Copy link
Author

codokie commented Aug 20, 2025

@GioSensation Sorry to bother you with this but I’ve seen that you were active in this repo in the past. I just have no idea who else could help me with this matter..

Do you by any chance know what is the process of approving a community translation?

I could take care of the conflicts but I’m starting to think that perhaps @duckduckgo is not really keen to get help from the community with translations. Hopefully I’m wrong..

#. Tells the user where to click in their browser. Part of a list of instructions on how to change the brower's home page.
msgid "Enter %shttps://duckduckgo.com%s"
msgstr "הכנסו ל-%shttps://duckduckgo.com%s"
msgstr "הזן %shttps://duckduckgo.com%s"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for typing into a field, so I guess the previous version was more correct?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The verb הזן means to type, while הכנסו ל means go to.

Since this string is used to instruct people to type a web address and not to go to a website, I think my version is more correct.


#. The name of the Fijian language
msgctxt "language_name"
msgid "Fijian"
msgstr ""
msgstr "פיג'ית"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double checking. Is this correct?

Copy link
Author

@codokie codokie Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the Hebrew Wikipedia page of Fiji as a reference. It lists פיג׳ית (transliteration is Fijit) as one of the official languages.

I haven’t been able to find a more reputable source sadly.


# Translator note: Is this a proper noun? Should it be translated?
Copy link
Member

@GioSensation GioSensation Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to translate. Leave it blank as it is.

@GioSensation
Copy link
Member

Thanks, @codokie. I've left just a couple of comments, but I will leave it to my colleague @thisisrajat to complete the review. FYI, I've seen quite a few deleted strings like this. Please make sure you revert those. And note that any change in the source string (you mentioned typos, etc.) will be overwritten and ignored, so please do not change any source string.

@codokie
Copy link
Author

codokie commented Aug 21, 2025

Thank you @GioSensation for taking the time to start a review of my translation. I understand it’s not an easy task when considering the amount of changes. I’ll try to be patient throughout the review process, although I do really hope it would be merged eventually in the not too far future.

FYI, I've seen quite a few deleted strings like [this](https://github.com/duckduckgo/duckduckgo-locales/pull/773/files#diff-336dd2358d48e9cb0eefae561893032de305f541e7aae6fcabadd059cbbb6024L141). Please make sure you revert those.

That is completely unintentional, it must be a processing bug of the tool called GTranslator which I’ve used. I’ll revert any change to the source strings. Thanks for telling me about this error!

And note that any change in the source string (you mentioned typos, etc.) will be overwritten and ignored, so please do not change any source string.

When I mentioned typos, I meant typos in the Hebrew translation only. I did not find any typo with the source strings. Sorry about the misunderstanding.

@codokie
Copy link
Author

codokie commented Aug 26, 2025

Okay I’ve added all the strings that were absent. It likely was due to a bad git merge, so not Gtranslator’s fault.

I’ve also translated the new strings from the past 4 months, and made very few corrections to my old translation.

It’s now ready for review. Any feedback from anyone is appreciated.

@thisisrajat
Copy link
Contributor

@codokie

Okay I’ve added all the strings that were absent. It likely was due to a bad git merge, so not Gtranslator’s fault.

I’ve also translated the new strings from the past 4 months, and made very few corrections to my old translation.

It’s now ready for review. Any feedback from anyone is appreciated.

Thank you for fixing that! I'll start reviewing this, but please bear with me as this is a big change, which we really appreciate! That said, I'll definitely get this merged.

@codokie
Copy link
Author

codokie commented Nov 8, 2025

I just found out about Unicode bidi support and I’m now curious if translated strings may contain Unicode characters. If so, I could embed directional formatting characters to ensure correct text rendering even without proper RTL support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants