Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat(pir): captcha providers #1550

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

madblex
Copy link

@madblex madblex commented Mar 7, 2025

Asana Task/Github Issue: https://app.asana.com/0/0/1209555302496203

Description

This PR:

  • refactors the captcha action handlers to enable extensibility (see associated tech design)
  • adds support for existing captcha providers: recaptcha, recaptcha enterprise, captcha (partially)
  • adds scaffolding for cloudflare turnstile
  • adds support for the new navigate action, already augmented with the new injectCaptchaHandler property (see associated tech design)
  • adds resolveActionHandlers resolver for the action handlers that uses a remote config to determine which version is used

TODO:

  • polish up the code, I am still deciding upon some patterns I used, names, etc
  • create remote config and wire up the value in resolveActionHandlers
  • manual testing
  • automated testing
  • reference asana tasks next to TODOs

Testing Steps

TODO

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Mar 7, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit eed4ba4
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67cb2dfec52aec00098f5682
😎 Deploy Preview https://deploy-preview-1550--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 7, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Mar 7, 2025

[Beta] Generated file diff

Time updated: Fri, 07 Mar 2025 17:34:53 GMT

Android
    - android/brokerProtection.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

Apple
    - dist/contentScopeIsolated.js

File has changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant