Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

history: empty state translations #1547

Merged
merged 4 commits into from
Mar 7, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Mar 6, 2025

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1209580853634537

Description

  • adding the languages

Testing Steps

image

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

netlify bot commented Mar 6, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit e04fe66
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67caf118aa7b6900089aa884
😎 Deploy Preview https://deploy-preview-1547--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane shakyShane marked this pull request as ready for review March 6, 2025 07:38
@shakyShane shakyShane requested review from mgurgel and a team as code owners March 6, 2025 07:38
Copy link

github-actions bot commented Mar 6, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Mar 6, 2025

[Beta] Generated file diff

Time updated: Fri, 07 Mar 2025 13:14:55 GMT

Integration
    - integration/pages/history/dist/index.js
  • integration/pages/history/locales/de/history.json
  • integration/pages/history/locales/en/history.json
  • integration/pages/history/locales/es/history.json
  • integration/pages/history/locales/fr/history.json
  • integration/pages/history/locales/it/history.json
  • integration/pages/history/locales/nl/history.json
  • integration/pages/history/locales/pl/history.json
  • integration/pages/history/locales/pt/history.json
  • integration/pages/history/locales/ru/history.json

File has changed

Windows
    - windows/pages/history/dist/index.js
  • windows/pages/history/locales/de/history.json
  • windows/pages/history/locales/en/history.json
  • windows/pages/history/locales/es/history.json
  • windows/pages/history/locales/fr/history.json
  • windows/pages/history/locales/it/history.json
  • windows/pages/history/locales/nl/history.json
  • windows/pages/history/locales/pl/history.json
  • windows/pages/history/locales/pt/history.json
  • windows/pages/history/locales/ru/history.json

File has changed

Apple
    - dist/pages/history/dist/index.js
  • dist/pages/history/locales/de/history.json
  • dist/pages/history/locales/en/history.json
  • dist/pages/history/locales/es/history.json
  • dist/pages/history/locales/fr/history.json
  • dist/pages/history/locales/it/history.json
  • dist/pages/history/locales/nl/history.json
  • dist/pages/history/locales/pl/history.json
  • dist/pages/history/locales/pt/history.json
  • dist/pages/history/locales/ru/history.json

File has changed

ayoy
ayoy previously approved these changes Mar 6, 2025
Copy link

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏆

@shakyShane shakyShane force-pushed the 03-06-history_empty_state_translations branch from 6efddd7 to 97868e9 Compare March 7, 2025 13:10
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and reviewed

@shakyShane shakyShane merged commit 931740f into main Mar 7, 2025
14 checks passed
@shakyShane shakyShane deleted the 03-06-history_empty_state_translations branch March 7, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants