Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity Widget: Ship Review feedback #1445

Closed

Conversation

greyivy
Copy link
Contributor

@greyivy greyivy commented Jan 30, 2025

Asana Task/Github Issue: https://app.asana.com/0/0/1209259671876424/f

Description

  • Fixes Google Ads tracker icon
  • Adds tooltips to tracker icons (parity with native)
  • Fixes middle clicking links

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@greyivy greyivy requested review from shakyShane, mgurgel and a team as code owners January 30, 2025 18:25
Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit f1589f9
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/679bedfb2fd1e200089e7a8a
😎 Deploy Preview https://deploy-preview-1445--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 30, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Jan 30, 2025

[Beta] Generated file diff

Time updated: Thu, 30 Jan 2025 21:30:24 GMT

Integration
    - integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js

File has changed

Apple
    - dist/pages/new-tab/dist/index.css
  • dist/pages/new-tab/dist/index.js

File has changed

@greyivy
Copy link
Contributor Author

greyivy commented Jan 30, 2025

This is ready for your review @shakyShane . I haven't been able to test the middle click stuff on macOS but it works as intended on Windows.

@shakyShane shakyShane force-pushed the 01-21-ntp_activity_widget branch 2 times, most recently from 2227fa2 to 7a597a2 Compare January 31, 2025 21:21
shakyShane added a commit that referenced this pull request Feb 2, 2025
@shakyShane shakyShane force-pushed the 01-21-ntp_activity_widget branch from 7a597a2 to b131675 Compare February 2, 2025 11:19
shakyShane added a commit that referenced this pull request Feb 2, 2025
@shakyShane shakyShane closed this Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants