Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malicious site protection - iOS Ship review feedback #1443

Merged
merged 7 commits into from
Feb 4, 2025

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Jan 30, 2025

Asana Task/Github Issue: https://app.asana.com/0/0/1209279366229521/f

Description

  1. Updated page title to Warning: This site may be a security risk
  2. Updated icon file
  3. Updated tab title to Warning: Security Risk
  4. Added hacks to prevent hanging words on some text blocks

Previews:

Testing Steps

  • Visit previews and confirm that copy is up-to-date

Checklist

<!—
These questions are a friendly reminder to shipping code, if you're uncertain ask the AoR owners.
It's also totally appropriate to not check some of these boxes, if they don't apply to your change.
—>
Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 653abfd
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67a2072409b1b20008596589
😎 Deploy Preview https://deploy-preview-1443--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 30, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Jan 30, 2025

[Beta] Generated file diff

Time updated: Tue, 04 Feb 2025 12:26:07 GMT

Integration
    - integration/pages/special-error/dist/index.css
  • integration/pages/special-error/dist/index.js
  • integration/pages/special-error/locales/bg/special-error.json
  • integration/pages/special-error/locales/cs/special-error.json
  • integration/pages/special-error/locales/da/special-error.json
  • integration/pages/special-error/locales/de/special-error.json
  • integration/pages/special-error/locales/el/special-error.json
  • integration/pages/special-error/locales/en/special-error.json
  • integration/pages/special-error/locales/es/special-error.json
  • integration/pages/special-error/locales/et/special-error.json
  • integration/pages/special-error/locales/fi/special-error.json
  • integration/pages/special-error/locales/fr/special-error.json
  • integration/pages/special-error/locales/hr/special-error.json
  • integration/pages/special-error/locales/hu/special-error.json
  • integration/pages/special-error/locales/it/special-error.json
  • integration/pages/special-error/locales/lt/special-error.json
  • integration/pages/special-error/locales/lv/special-error.json
  • integration/pages/special-error/locales/nb/special-error.json
  • integration/pages/special-error/locales/nl/special-error.json
  • integration/pages/special-error/locales/pl/special-error.json
  • integration/pages/special-error/locales/pt/special-error.json
  • integration/pages/special-error/locales/ro/special-error.json
  • integration/pages/special-error/locales/ru/special-error.json
  • integration/pages/special-error/locales/sk/special-error.json
  • integration/pages/special-error/locales/sl/special-error.json
  • integration/pages/special-error/locales/sv/special-error.json
  • integration/pages/special-error/locales/tr/special-error.json

File has changed

Apple
    - dist/pages/special-error/dist/index.css
  • dist/pages/special-error/dist/index.js
  • dist/pages/special-error/index.html
  • dist/pages/special-error/locales/bg/special-error.json
  • dist/pages/special-error/locales/cs/special-error.json
  • dist/pages/special-error/locales/da/special-error.json
  • dist/pages/special-error/locales/de/special-error.json
  • dist/pages/special-error/locales/el/special-error.json
  • dist/pages/special-error/locales/en/special-error.json
  • dist/pages/special-error/locales/es/special-error.json
  • dist/pages/special-error/locales/et/special-error.json
  • dist/pages/special-error/locales/fi/special-error.json
  • dist/pages/special-error/locales/fr/special-error.json
  • dist/pages/special-error/locales/hr/special-error.json
  • dist/pages/special-error/locales/hu/special-error.json
  • dist/pages/special-error/locales/it/special-error.json
  • dist/pages/special-error/locales/lt/special-error.json
  • dist/pages/special-error/locales/lv/special-error.json
  • dist/pages/special-error/locales/nb/special-error.json
  • dist/pages/special-error/locales/nl/special-error.json
  • dist/pages/special-error/locales/pl/special-error.json
  • dist/pages/special-error/locales/pt/special-error.json
  • dist/pages/special-error/locales/ro/special-error.json
  • dist/pages/special-error/locales/ru/special-error.json
  • dist/pages/special-error/locales/sk/special-error.json
  • dist/pages/special-error/locales/sl/special-error.json
  • dist/pages/special-error/locales/sv/special-error.json
  • dist/pages/special-error/locales/tr/special-error.json

File has changed

New Files
    - integration/pages/special-error/dist/Malware-Site-128-YUDZDGMR.svg
  • dist/pages/special-error/dist/Malware-Site-128-YUDZDGMR.svg

❌ File only exists in new changeset

@mgurgel mgurgel self-assigned this Jan 30, 2025
@mgurgel mgurgel changed the title Malicious site protection - iOS copy review Malicious site protection - Copy review Jan 30, 2025
@mgurgel mgurgel changed the title Malicious site protection - Copy review Malicious site protection - iOS Ship review feedback Jan 30, 2025
@mgurgel mgurgel marked this pull request as ready for review February 4, 2025 12:24
@mgurgel mgurgel requested review from shakyShane and a team as code owners February 4, 2025 12:24
@mgurgel mgurgel force-pushed the mgurgel/malicious-site-copy-update branch from ef78b66 to 653abfd Compare February 4, 2025 12:25
@mgurgel mgurgel merged commit 16f46f6 into main Feb 4, 2025
13 checks passed
@mgurgel mgurgel deleted the mgurgel/malicious-site-copy-update branch February 4, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants