Support elements that only contain textContent, remove commas from the end of addresses #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Thu, 30 Jan 2025 09:29:04 GMT IntegrationFile has changed WindowsFile has changed AppleFile has changed |
brianhall
changed the title
brianhall
commented
Jan 30, 2025
shakyShane
approved these changes
Jan 30, 2025
mgurgel
pushed a commit
that referenced
this pull request
Feb 3, 2025
…e end of addresses (#1440) * Support textNodes, remove commas from the end of addresses * Restructure the textContent statement * Make code more testable, add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue:
Description
When using XPath’s text() node test (e.g.
//strong[contains(text(), 'Locations:')]/following-sibling::text()), a node is returned that only contains textContent, not innerText.This change updates the extractor to check for innerText, and fallback to textContent. Also included, a small change to strip out commas at the end of addresses.
Testing Steps
Checklist
Please tick all that apply: