Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass message value to so it applies for priviledged domains #1425

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Jan 24, 2025

Asana Task/Github Issue: https://app.asana.com/0/414235014887631/1209235566031320/f

Description

This bug was only visible in production because the navigatorInterface is injected via a different path when it’s a privileged domain. (which has a different payload).

This means all local testing (using domains like ngrok) did not hightlight this problem

Testing Steps

  • Tests on the production SERP with latest iOS

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 1fc8e34
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/6793accfa3f8010008074896
😎 Deploy Preview https://deploy-preview-1425--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Jan 24, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Jan 24, 2025

[Beta] Generated file diff

Time updated: Fri, 24 Jan 2025 15:13:59 GMT

Android
    - android/autofillPasswordImport.js
  • android/contentScope.js

File has changed

Chrome
    - chrome/inject.js

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

Apple
    - dist/contentScope.js
  • dist/contentScopeIsolated.js

File has changed

@shakyShane shakyShane marked this pull request as ready for review January 24, 2025 15:13
@shakyShane shakyShane requested review from a team as code owners January 24, 2025 15:13
Copy link
Member

@muodov muodov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shakyShane shakyShane merged commit ad9bc97 into main Jan 24, 2025
20 checks passed
@shakyShane shakyShane deleted the 01-24-pass_message_value_to_so_it_applies_for_priviledged_domains branch January 24, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants