Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp: fix regression with theme context/text color #1409

Merged

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Jan 17, 2025

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1209184777639415/f

Description

The customizer button now sits outside of any theme context (this change was to fix a different bug 😢 ) - which meant it lost the context of which theme it should fall under.

This PR just adds an additional wrapper to put the context back in place. There may be a better way, but for now this solves the problem.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 5e25e24
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/678abf8fcb6776000859c4af
😎 Deploy Preview https://deploy-preview-1409--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 17, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Jan 17, 2025

[Beta] Generated file diff

Time updated: Fri, 17 Jan 2025 20:41:47 GMT

Integration
    - integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js

File has changed

Apple
    - dist/pages/new-tab/dist/index.css
  • dist/pages/new-tab/dist/index.js

File has changed

@shakyShane shakyShane marked this pull request as ready for review January 17, 2025 20:40
@shakyShane shakyShane requested review from mgurgel and a team as code owners January 17, 2025 20:40
@shakyShane shakyShane merged commit 61e21b2 into main Jan 17, 2025
20 checks passed
@shakyShane shakyShane deleted the 01-17-ntp_fix_regression_with_theme_context_text_color branch January 17, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants