Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autofill password import] animate export password only once #1400

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dbajpeyi
Copy link
Contributor

@dbajpeyi dbajpeyi commented Jan 14, 2025

Asana Task/Github Issue: https://app.asana.com/0/1203822806345703/1209143210450862/f

Description

Whenever there's path change, there's a call to animateOrTapElement. This is not a problem for most transitions, but in case of the export button the excessive tapping causes too aggressive UX:
Screen Recording 2025-01-14 at 10 26 57

This PR ads an internal state called tapOnce to the element config, to avoid tapping multiple times for certain elements.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit a2a7b09
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/679c7a4875f6fc0008716280
😎 Deploy Preview https://deploy-preview-1400--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 14, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Jan 14, 2025

[Beta] Generated file diff

Time updated: Fri, 31 Jan 2025 07:23:43 GMT

Android
    - android/autofillPasswordImport.js

File has changed

Integration
    - integration/contentScope.js

File has changed

@dbajpeyi dbajpeyi force-pushed the dbajpeyi/fix/animate-export-once branch from 766ac48 to 591dcc0 Compare January 28, 2025 06:26
@dbajpeyi dbajpeyi changed the title fix: animate export password only once [Autofill password import] animate export password only once Jan 28, 2025
@dbajpeyi dbajpeyi marked this pull request as ready for review January 28, 2025 06:36
@dbajpeyi dbajpeyi requested a review from a team as a code owner January 28, 2025 06:36
@dbajpeyi dbajpeyi force-pushed the dbajpeyi/fix/animate-export-once branch from 84ee82f to fc9c1d4 Compare January 28, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant