Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed desktop duckplayer regression #1031

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Sep 9, 2024

https://app.asana.com/0/0/1208262252204250/f

1: A small regression on Desktop - where the height of the player was incorrect in certain configurations - see the video.
2: updated the dax icon, as per: https://app.asana.com/0/1201141132935289/1208258231758532/f

dp-bug.mp4

@shakyShane
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

@shakyShane shakyShane marked this pull request as ready for review September 9, 2024 15:37
Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

github-actions bot commented Sep 9, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane merged commit eb085c7 into main Sep 9, 2024
8 checks passed
@shakyShane shakyShane deleted the 09-09-fixed_desktop_duckplayer_regression branch September 9, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants