give a theme context to customizer button

duckduckgo · Jan 17, 2025 · 3a26c45 · 3a26c45
1 parent 14619c2
commit 3a26c45
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 17 deletions.
diff --git a/special-pages/pages/new-tab/app/components/App.js b/special-pages/pages/new-tab/app/components/App.js
@@ -61,20 +61,21 @@ export function App() {
                         </div>
                     </div>
                 </main>
-                <CustomizerMenuPositionedFixed>
-                    {customizerKind === 'menu' && <CustomizerMenu />}
-                    {customizerKind === 'drawer' && (
-                        <CustomizerButton
-                            buttonId={buttonId}
-                            menuId={drawerId}
-                            toggleMenu={toggle}
-                            buttonRef={buttonRef}
-                            isOpen={isOpen}
-                            kind={'drawer'}
-                            theme={main}
-                        />
-                    )}
-                </CustomizerMenuPositionedFixed>
+                <div data-theme={main}>
+                    <CustomizerMenuPositionedFixed>
+                        {customizerKind === 'menu' && <CustomizerMenu />}
+                        {customizerKind === 'drawer' && (
+                            <CustomizerButton
+                                buttonId={buttonId}
+                                menuId={drawerId}
+                                toggleMenu={toggle}
+                                buttonRef={buttonRef}
+                                isOpen={isOpen}
+                                kind={'drawer'}
+                            />
+                        )}
+                    </CustomizerMenuPositionedFixed>
+                </div>
                 {customizerKind === 'drawer' && (
                     <aside
                         class={cn(styles.aside, styles.asideLayout, styles.asideScroller)}

diff --git a/special-pages/pages/new-tab/app/customizer/components/CustomizerMenu.js b/special-pages/pages/new-tab/app/customizer/components/CustomizerMenu.js
@@ -112,10 +112,9 @@ export function useContextMenu() {
  * @param {import("@preact/signals").Signal<boolean>|boolean} props.isOpen
  * @param {() => void} [props.toggleMenu]
  * @param {import("preact").Ref<HTMLButtonElement>} [props.buttonRef]
- * @param {import('@preact/signals').Signal<'light' | 'dark'>} [props.theme]
  * @param {"menu" | "drawer"} props.kind
  */
-export function CustomizerButton({ menuId, buttonId, isOpen, toggleMenu, buttonRef, kind, theme }) {
+export function CustomizerButton({ menuId, buttonId, isOpen, toggleMenu, buttonRef, kind }) {
     const { t } = useTypedTranslation();
     return (
         <button
@@ -126,7 +125,6 @@ export function CustomizerButton({ menuId, buttonId, isOpen, toggleMenu, buttonR
             aria-expanded={isOpen}
             aria-controls={menuId}
             data-kind={kind}
-            data-theme={theme}
             id={buttonId}
         >
             <CustomizeIcon />