Skip to content

Support shadowDOM version of axeptio #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Support shadowDOM version of axeptio #837

wants to merge 10 commits into from
+35 −13

Conversation

muodov
Copy link
Member

@muodov muodov commented Jul 21, 2025

@muodov muodov requested review from Copilot and sammacbeth July 21, 2025 09:34
@muodov muodov added minor Increment the minor version when merged release Create a release when this pr is merged labels Jul 21, 2025
Copilot

This comment was marked as outdated.

Sign in to view

sammacbeth
sammacbeth requested changes Jul 23, 2025
View reviewed changes
Copy link
Collaborator

@sammacbeth sammacbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In testing, the shadow dom-ed versions didn't work for me. I see the popup starting to hide, but then it comes back again. Maybe we're too fast?

lib/web.ts

async waitForPopup(cmp: AutoCMP, retries = 5, interval = 500): Promise<boolean> {
// TODO: use MutationObserver like in findCmp()
async waitForPopup(cmp: AutoCMP, retries = 10, interval = 500): Promise<boolean> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muodov did you mean to make this change?

tests/axeptio.spec.ts Outdated
generateCMPTests('axeptio', ['https://www.welcometothejungle.com/', 'https://frichti.co/landing?redirectTo=/', 'https://www.dorcel.com/']);
generateCMPTests('axeptio', [
'https://www.welcometothejungle.com/',
'https://frichti.co/landing?redirectTo=/',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my testing this site was using com_didomi.io.

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

sammacbeth
sammacbeth requested changes Oct 13, 2025
View reviewed changes
Copy link
Collaborator

@sammacbeth sammacbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this still doesn't work for all of the test cases...

rules/autoconsent/axeptio.json
"click": "button#axeptio_btn_dismiss"
"if": { "exists": ".axeptio_mount .needsclick" },
"then": [
{ "waitForVisible": [".axeptio_mount .needsclick", "button#axeptio_btn_dismiss"] },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On https://www.narbonneaccessoires.fr/fr-fr/ the rule is failing here. Looks like the reject button doesn't get a dismiss ID that we can click.
Uploading Screenshot 2025-10-13 at 14.31.54.png…

@daxtheduck
Copy link
Collaborator

CI run finished. Artifacts ZIP for the review tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@sammacbeth sammacbeth sammacbeth requested changes

@noisysocks noisysocks Awaiting requested review from noisysocks

Assignees

No one assigned

Labels

minor Increment the minor version when merged release Create a release when this pr is merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@muodov @daxtheduck @sammacbeth