Split m.mac.fire.window.configuration.daily into individual pixels by parameter

[miasma13]

Task/Issue URL: https://app.asana.com/1/137249556945/project/1201048563534612/task/1211634786160239?focus=true
Tech Design URL:
CC:

Description

To use long term stats from the aggregate table we need to move from using pixel with parameters to individual pixels.
Scope of changes:

• remove m.mac.fire.window.configuration.daily that contains 3 parameters (fire_animation_enabled, open_fire_window_by_default, startup_fire_window)
• add new separate pixels:
  • m_mac_fire_window_configuration_startup_fire_window_is_enabled_daily
  • m_mac_fire_window_configuration_startup_fire_window_is_disabled_daily
  • m_mac_fire_window_configuration_open_fire_window_by_default_is_enabled_daily
  • m_mac_fire_window_configuration_open_fire_window_by_default_is_disabled_daily
  • m_mac_fire_window_configuration_fire_animation_is_enabled_daily
  • m_mac_fire_window_configuration_fire_animation_is_disabled_daily

Testing Steps

1. Run the app
2. On startup:

• Verify that old pixel is no longer fired
• Verify that new pixels are fired in set of 3 (one pixel per feature)
• Changing app settings fires appropriate enabled/disabled pixel variant

Impact and Risks

None: Internal tooling, documentation

What could go wrong?

Pixel changes, problems with dashboards.

Quality Considerations

Notes to Reviewer

---

Internal references:

Definition of Done | Engineering Expectations | Tech Design Template

---

Note

Replaces the single parameterized fire window configuration daily pixel with three distinct per-setting pixels and updates AppDelegate to fire each daily.

• Telemetry/Statistics:
  • Replace GeneralPixel.dailyFireWindowConfiguration(...) with three explicit events:
    • dailyFireWindowConfigurationStartupFireWindowEnabled(startupFireWindow: Bool) → names m_mac_fire_window_configuration_startup_fire_window_is_enabled|disabled
    • dailyFireWindowConfigurationOpenFireWindowByDefaultEnabled(openFireWindowByDefault: Bool) → names ..._open_fire_window_by_default_is_enabled|disabled
    • dailyFireWindowConfigurationFireAnimationEnabled(fireAnimationEnabled: Bool) → names ..._fire_animation_is_enabled|disabled
  • Remove parameters for the old combined pixel and add enabled/disabled name variants.
• App lifecycle (AppDelegate):
  • Replace fireDailyFireWindowConfigurationPixel() with fireDailyFireWindowConfigurationPixels() and fire the three new pixels daily on applicationDidBecomeActive.

^{Written by Cursor Bugbot for commit 99c8abd. This will update automatically on new commits. Configure here.}

[Copilot]

Pull Request Overview

Splits the previous aggregated fire window configuration daily pixel into three distinct pixels, each representing a specific configuration flag, removing parameterized payloads in favor of explicit pixel name variants.

• Replaces single dailyFireWindowConfiguration pixel with three dedicated enum cases.
• Adjusts AppDelegate to fire three separate daily pixels instead of one aggregated pixel with parameters.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
macOS/DuckDuckGo/Statistics/GeneralPixel.swift	Replaced aggregated enum case and dynamic params with three discrete pixel cases and name generation logic.
macOS/DuckDuckGo/Application/AppDelegate.swift	Updated to fire the new three daily configuration pixels individually.

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[cursor]

Bug: Daily Pixel Naming Inconsistency

The new dailyFireWindowConfiguration pixel names are missing the _daily suffix specified in the PR description. This discrepancy means analytics tooling and dashboards may not correctly recognize these pixels.

 

[hanyutang-sandra]

LGTM