-
Notifications
You must be signed in to change notification settings - Fork 31
macOS: Localize and release the option to clear Duck.ai chat history #2212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: rachel/chat-history-integrate-css
Are you sure you want to change the base?
macOS: Localize and release the option to clear Duck.ai chat history #2212
Conversation
🌍 Smartling Translation Job CreatedJob ID: Next:
|
✅ Smartling Job ApprovedJob ID: Translation has been authorized and is now in progress. Next: Check status with: |
&& mode.shouldShowChatHistoryToggle | ||
&& (clearingOption.shouldShowChatHistoryToggle || isPresentedOnAIChatTab) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicky - but I'd consider indenting this a bit as it looks a bit odd right now.
Thanks! Once the translations are added to this PR, I’ll merge all of my work back into a single branch. |
Task/Issue URL: https://app.asana.com/1/137249556945/project/72649045549333/task/1211370814674975?focus=true
Tech Design URL:
CC: @diegoreymendez
Description
This incudes the last steps to release the option to clear Duck.ai chat history:
Testing Steps
Impact and Risks
Low: Minor visual changes, small bug fixes, improvement to existing features
What could go wrong?
Manually tested to confirm strings appear as expected in English and Double Pseudo-language.
Quality Considerations
Notes to Reviewer
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template
Note
Localizes Duck.ai chat-clearing strings, shows the Fire dialog chat toggle when the active tab is Duck.ai, and switches the
duckAiDataClearing
flag to remote releasable.FireDialogViewModel.shouldShowChatHistoryToggle
).NSLocalizedString
keys inUserText.swift
(e.g.,fire.dialog.chats.title
,fire.dialog.chats.subtitle
,history.delete.dialog.chats.checkbox.*
,automatically.clear.chats
,warn.before.quit.clearChats*
,fire.active-tabs-and-chats-info
).Localization/Localizable.xcstrings
.FeatureFlag.duckAiDataClearing
source toremoteReleasable
inFeatureFlag.swift
.Written by Cursor Bugbot for commit 6d547eb. This will update automatically on new commits. Configure here.